Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way change detection is enabled & disabled again #178

Open
kaosat-dev opened this issue Apr 5, 2024 · 0 comments · May be fixed by #170 or #192
Open

Change the way change detection is enabled & disabled again #178

kaosat-dev opened this issue Apr 5, 2024 · 0 comments · May be fixed by #170 or #192
Labels

Comments

@kaosat-dev
Copy link
Owner

kaosat-dev commented Apr 5, 2024

Up until now, change detection was

  • disabled before an export (so that all the changes we make are not registered)
  • enabled again with a one second timer after the call to export

Turns out, based on the newly added better change detection tests:

  • that they do not get enabled again correctly , at least in cli mode (timer does not run ?)
  • but also very importantly, that the logic behind enabling them again is WRONG : it should only happen after the export is REALLY done: so we should switch this to use the post export hooks (glTF2_post_export_callback)!

This could potentially explain the observed semi random weirdness around change detection ! (both it not working for some folks, and running too much for others !)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant