Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting: Avoid unnecessary null values #2

Closed
tomli380576 opened this issue Aug 22, 2022 · 3 comments
Closed

Linting: Avoid unnecessary null values #2

tomli380576 opened this issue Aug 22, 2022 · 3 comments
Assignees
@tomli380576
Labels
P5 Lowest priority question Further information is requested wontfix This will not be worked on

Comments

@tomli380576
Copy link
Collaborator

tomli380576 commented Aug 22, 2022 •
edited
Loading

  1. Avoid unnecessary null class members
  2. Use nullish coalescing
  3. Prefer const and remove null initializations
@tomli380576 tomli380576 changed the title Linting: Avoid unecessary null class members Linting: Avoid unnecessary null values Aug 22, 2022
@tomli380576 tomli380576 self-assigned this Aug 23, 2022
@tomli380576
Copy link
Collaborator Author

This branch will be based on #4

@tomli380576 tomli380576 added code improvement coding style, linting, etc. P2 High priority labels Aug 23, 2022
@tomli380576 tomli380576 linked a pull request Aug 24, 2022 that will close this issue
Linting: Enforce triple equals and remove unnecessary null values #17
Closed
@tomli380576
Copy link
Collaborator Author

tomli380576 commented Aug 24, 2022 •
edited
Loading

DO NOT merge yet, might be a breaking change
It's hard to tell if Noah was coercing undefined and null.
The rewrite branches will fix this

@tomli380576 tomli380576 added question Further information is requested P5 Lowest priority wontfix This will not be worked on and removed code improvement coding style, linting, etc. P2 High priority labels Aug 26, 2022
@tomli380576
Copy link
Collaborator Author

Revamped in new design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomli380576 tomli380576

Labels
P5 Lowest priority question Further information is requested wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
1 participant
@tomli380576