Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataset-download-options endpoint #65

Merged
merged 1 commit into from Mar 8, 2022

Conversation

aazuspan
Copy link
Contributor

@aazuspan aazuspan commented Mar 8, 2022

This PR would close #64 by adding an api.dataset_download_options function to access the dataset-download-options endpoint.

It also adds the necessary payload and unit tests.

Let me know if you see and changes needed, @kapadia :)

P.S. I didn't implement the sceneFilter parameter that the endpoint accepts because it would complicate the implementation and, to be honest, I don't understand the point of it. Seems to me that if someone wants to know product availability for specific filters they'll be using those filters to find scenes and checking products for those scenes with the download-options endpoint. But maybe there's an application I'm not thinking of. Let me know if you think that's important and I can add it.

@kapadia
Copy link
Owner

kapadia commented Mar 8, 2022

Looks great, thanks @aazuspan! I take the point on scene filter, those can be complicated.

@kapadia kapadia merged commit b6da3d8 into kapadia:master Mar 8, 2022
@kapadia
Copy link
Owner

kapadia commented Mar 8, 2022

A new package with your contributions are on PyPI.

@aazuspan
Copy link
Contributor Author

aazuspan commented Mar 8, 2022

Thanks @kapadia!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New endpoint for dataset-download-options
2 participants