Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRV Record Support. #53

Closed
Myvar opened this issue Jan 31, 2019 · 4 comments
Closed

SRV Record Support. #53

Myvar opened this issue Jan 31, 2019 · 4 comments

Comments

@Myvar
Copy link

Myvar commented Jan 31, 2019

Please add support for SRV Record.

Originally posted by @AlexLaroche in #22 (comment)

I need this support as well, i don't mind implementing it my self, would you mind just giving me a brief description on how to do this, or any docs on dns that i might need, then il fork the project and make pr once i get it working ?

@danieljoos
Copy link
Contributor

The implementation can be done by adding a new SrvResourceRecord (or so) class in the /DNS/Protocol/ResourceRecords folder.
You can have a look at other kinds of records there, e.g. the IP Address RR, here:
https://github.com/kapetan/dns/blob/master/DNS/Protocol/ResourceRecords/IPAddressResourceRecord.cs

Those classes basically have two constructors:

  1. One that takes the base ResourceRecord object. This is used when the client parses records.
  2. Another one that is used for the DNS server use-case, where you want to construct a RR that is provided via your server.

The wiring of those classes to the actual RR type is done in the ResourceRecordFactory:
https://github.com/kapetan/dns/blob/master/DNS/Protocol/ResourceRecords/ResourceRecordFactory.cs

The SRV Resource Records are described in RFC2782:
https://www.ietf.org/rfc/rfc2782.txt

@Myvar
Copy link
Author

Myvar commented Feb 1, 2019

Il take a crack at it.

@Myvar
Copy link
Author

Myvar commented Feb 1, 2019

#54 Done.

In my mind i imagined this taking hours but it was actually not that bad.

@kapetan
Copy link
Owner

kapetan commented Sep 5, 2020

Added SRV record implementation 7673e95

@kapetan kapetan closed this as completed Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants