Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to automatically strip .DS_Store files when uploading on Mac #25

Closed
dia3olik opened this issue Oct 26, 2019 · 27 comments
Closed
Labels
enhancement New feature or request will be fixed in the next relase fix is already done and will be included in the next release
Milestone

Comments

@dia3olik
Copy link

Hey man!

firstly I wanted to thank you for picking up the project, it really needed an update and a future!!! ;-)

Back on topic, I think an easy and quick option (even "on" by default maybe?) to filter out on upload all the .DS_Store files on each directory which MacOs creates would be really really handy for less experienced users since it would be less cumbersome and straightforward than dealing with custom filtering timeline option strings each time ;-)

What do you think?

@kapitainsky
Copy link
Owner

Not sure. Any files can be excluded right now in job preferences if somebody wishes. At the same time .DS_Store files are tiny and there is no harm in copying them. Myself when I copy folder I want everything to be included unless I specify otherwise - I don't like silent default exclusion.

@Alphos2000
Copy link

Alphos2000 commented Oct 26, 2019

And would be possible to save the exclude file list, so you don't have to write it everytime? Maybe a box to activate or desactivate filelist, and it always is stored sou you dont have to write it always.

@kapitainsky
Copy link
Owner

I am thinking about adding default extra arguments option in general settings. They would be applied to any new job. It is the most universal and solves many issues including default exclusion list e.g. you could specify in setting "--exclude-from file".

@kapitainsky kapitainsky added the enhancement New feature or request label Oct 27, 2019
@dia3olik
Copy link
Author

This would be close enough and also universal for various needs, it's a cool idea regardless ;-)
Thanks!!!
But I still think that on the Mac build a simple toggle on/off to exclude all .DS_Store files would be a godsend for speed and to keep things simple, these pesky files are not needed for the kind of files/folders you want to upload to the cloud...and can lead to cleaner folders on the cloud.

@kapitainsky
Copy link
Owner

In just released 1.6.0 I have included default job options. It means that now it is easy to have "--exclude-from file" by default for every new Upload.

@kapitainsky
Copy link
Owner

I will take a note and for the next release I can make for macOS default options for Upload "--exclude .DS_Store" so total new users will have it on from first install.

Try latest release and let me know if any issues.

@dia3olik
Copy link
Author

Thanks! That was quick!!! ;-)
I totally agree, that would be a very good way indeed.

@kapitainsky kapitainsky reopened this Oct 28, 2019
@kapitainsky kapitainsky added this to the 1.6.1 milestone Oct 28, 2019
@kapitainsky
Copy link
Owner

Done in commit aa826eb

Will roll out with the next release. no ETA atm

@kapitainsky kapitainsky added the will be fixed in the next relase fix is already done and will be included in the next release label Oct 29, 2019
@dia3olik
Copy link
Author

I just tried on an upload with latest versions (1.6.0 + rclone 1.50.1) and with the default option "--exclude .DS_Store" it still uploads these...strange! what could be the culprit?? thanks!

@kapitainsky
Copy link
Owner

can you post screenshot of your job? I tested it myself and it works

@kapitainsky
Copy link
Owner

you can also try the next release preview

https://www.icloud.com/iclouddrive/0TXekZ4JL1TAANEGhM3IGReNQ#rclone-browser-1.6.0-409180a-macOS

Final release will probably include more fixes but .DS_Store is already there

@dia3olik
Copy link
Author

Hi! I just tried again with 1.7.0 and it still uploads .DS_Store files...

@kapitainsky kapitainsky reopened this Dec 11, 2019
@kapitainsky
Copy link
Owner

have you put "--exclude .DS_Store" in default upload options? It is set for new rclone browser installations on macOS but for existing ones I don't change anything

@dia3olik
Copy link
Author

yes of course but it's ignoring it completely...

@kapitainsky
Copy link
Owner

Screenshot 2019-12-11 at 12 30 11 1

@kapitainsky kapitainsky added the bug Something isn't working label Dec 11, 2019
@kapitainsky
Copy link
Owner

kapitainsky commented Dec 11, 2019

Ok. I see where the issue is. Stupid bug.

It works when you save your upload as a task and then run it. When you run it directly options are ignored. Will be fixed. In the meantime go through task step.

@kapitainsky
Copy link
Owner

it is strange. As it works now for me. I will have to investigate it more

@kapitainsky
Copy link
Owner

I did few tests.... and it works... Could you please try again - just make sure that transfer window had default exclude
Screenshot 2019-12-11 at 13 37 49

I think in my first test I pressed restore defaults and extra options were cleared... I should change this behaviour as default extras should be one set in preferences.

@kapitainsky
Copy link
Owner

You can also clean already uplaoded .DS_Store files by running sync (not copy) and specifying following:

Screenshot 2019-12-11 at 13 27 01

@dia3olik
Copy link
Author

Thanks for the tip, yeah I have the option enabled but it's ignored...

I have the files on a NAS shared with AFP to my Mac on which I have installed RCB.

I'll try to do a screen rec and upload it to show you...in the mean time how can I batch delete all the .DS_Store files on the remote if I don't have the local source directory anymore to sync it from?

Thanks!

@kapitainsky
Copy link
Owner

https://rclone.org/commands/rclone_delete/

for this you need cmd rclone. Assuming that your data is stored on remote in /Testing folder

rclone delete --dry-run --include .DS_Store remote:/Testing/

run this with --dry-run first to double check what will be deleted

@dia3olik
Copy link
Author

thanks man!

I'll keep you updated ;-)

BTW it would be nice to implement a selective search&delete feature on RCB ;-)

@kapitainsky
Copy link
Owner

I thought about it. Simply I can add delete option... but... I am afraid of power of this command.

People spend days uploading their stuff to slow remote and then one wrong click and all can be gone. There is always cmd for power users.

@dia3olik
Copy link
Author

you're right but maybe you can implement it with many warnings and maybe with --dry-run as default?

@kapitainsky
Copy link
Owner

kapitainsky commented Dec 20, 2019

I have tested on few different macs and when "--exclude .DS_Store” is specified in extra options .DS_Store files are ignored. Maybe you had some typo in extra options? Or still it is reproducible issue?

@dia3olik
Copy link
Author

the default you wrote in the current version is --exclude ".DS_Store" so maybe this is the culprit? If it is please correct it in the next version to be "--exclude .DS_Store”

@kapitainsky kapitainsky removed the bug Something isn't working label Dec 26, 2019
@kapitainsky
Copy link
Owner

It has been fixed in the latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request will be fixed in the next relase fix is already done and will be included in the next release
Projects
None yet
Development

No branches or pull requests

3 participants