New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force kill ffmpeg process when Timeout::Error occurs in #stop_ffmpeg. #60

Closed

kapoorlakshya opened this issue Apr 11, 2019 · 0 comments · Fixed by #63

Labels

Milestone

Owner

kapoorlakshya commented Apr 11, 2019 •

edited

Will need OS specific logic. This one works on macOS and possibly on Linux:

def stop_ffmpeg
# ...
rescue Timeout::Error
  ScreenRecorder.logger.error 'FFmpeg failed to stop. Force killing it...'
  pid = (@process.pid + 1) # Parent process + 1
  Process.kill 'TERM', pid
end

Could combine with #18.

kapoorlakshya added the bug label

kapoorlakshya added this to the v1.1.0 milestone

kapoorlakshya mentioned this issue

Force kill ffmpeg process on Timeout::Error. #63

Merged

kapoorlakshya added enhancement and removed bug labels

kapoorlakshya closed this as completed in #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment