Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not recognise class-based size #36

Closed
judgej opened this issue Jun 17, 2014 · 2 comments
Closed

Does not recognise class-based size #36

judgej opened this issue Jun 17, 2014 · 2 comments

Comments

@judgej
Copy link

judgej commented Jun 17, 2014

On FF at least.

I find I MUST use a style attribute to set the width and height of the containing block. A width or height set via a class on that block simply does not work - it leaves the block empty, devoid of any images at all.

This is quite a restriction, especially on systems where the size of the block will vary and is not fixed in the markup. Most responsive sites will be like this. The plugin needs to be able to read the calculated size of the block, and maybe even track changes to that size as the page is resized. Without that, it does not play well with modern web techniques and so should probably be avoided.

@karacas
Copy link
Owner

karacas commented Jun 17, 2014

Judhej, in this example set size via class works fine:

  http://jsfiddle.net/GvBC3/

Can you make a jsfiddle with a error?
Tnx

@judgej
Copy link
Author

judgej commented Jun 17, 2014

Yes, you are right. I'll do a bit more digging in the theme we are running to see what it could be interacting with the plugin, then put together the minimum example.

@karacas karacas closed this as completed Jun 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants