Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire the client stubs and replace them with alternative client after WaterDrop 2.6.0 release #142

Closed
mensfeld opened this issue Jun 7, 2023 · 2 comments · Fixed by #146
Closed

Retire the client stubs and replace them with alternative client after WaterDrop 2.6.0 release #142

mensfeld opened this issue Jun 7, 2023 · 2 comments · Fixed by #146
Assignees
@mensfeld
Labels
enhancement New feature or request

Comments

@mensfeld
Copy link
Member

mensfeld commented Jun 7, 2023

No description provided.

@mensfeld mensfeld added the enhancement New feature or request label Jun 7, 2023
@mensfeld mensfeld self-assigned this Jun 7, 2023
@mensfeld
Copy link
Member Author

released: https://github.com/karafka/waterdrop/releases/tag/v2.6.0

@mensfeld
Copy link
Member Author

Closing. We cannot do it because we inject rspec to direct waterdrop client

@jordanfbrown jordanfbrown mentioned this issue Jun 12, 2023
Closed
@mensfeld mensfeld reopened this Jun 13, 2023
@mensfeld mensfeld mentioned this issue Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mensfeld mensfeld

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use correct buffered client reference from WaterDrop karafka/karafka-testing
1 participant
@mensfeld