Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prime-factorization is wrong #19

Closed
madsulrik opened this issue Aug 1, 2013 · 3 comments
Closed

Prime-factorization is wrong #19

madsulrik opened this issue Aug 1, 2013 · 3 comments

Comments

@madsulrik
Copy link

Your prime-factorization code give the wrong result.
ex.
number = 12
>>> [2,3]

when i actually have to be:
>>> [2,2,3]

You can check the version I have on my repository.

@c1b3rh4ck
Copy link

You're rigth,you can create a pull request to solve the problem,the other can fetch changes from origin.

@madsulrik
Copy link
Author

Not a wild change. I have just created a pull request on that file. So it should work now!

@karan
Copy link
Owner

karan commented Aug 2, 2013

I actually just printed the unique primes. I've fixed the code, but not merged the pull request..

@karan karan closed this as completed Aug 2, 2013
@karan karan mentioned this issue Aug 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants