Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple preview environments under different sub domains #12

Open
chris-hinds opened this issue Jul 28, 2022 · 4 comments
Open

Comments

@chris-hinds
Copy link

Hi, this looks great. Was wondering if this supports multiple branches. being pushed i.e. a preview env per branch each on a different subdomain.

From what I can see this will just work until one single domain currently.

@karanpratapsingh
Copy link
Owner

karanpratapsingh commented Jul 28, 2022

Hi @chris-hinds, yes this supports N different subdomains.

For example,

feat/branch-x ----> feat-branch-x.domain.com
feat/branch-y ----> feat-branch-y.domain.com

@chris-hinds
Copy link
Author

chris-hinds commented Jul 28, 2022

Thanks, @karanpratapsingh are you pointing the Cloudflare domains to a load balancer in front of ECS? Or directly to the VPC? If so how do the subdomains know which ECS task to point to?

Apologies if I missed where this logic is.

@karanpratapsingh
Copy link
Owner

Traffic from the ECS tasks is proxied to Cloudflare DNS using Cloudflare Argo tunnels. So, ECS service can run in private subnet without exposing to internet unsafely

@chris-hinds
Copy link
Author

chris-hinds commented Aug 11, 2022

@karanpratapsingh How could this be hooked into an ECS Service? I mostly have this working but I am using a load balancer that requires an ECS service.

I have the scripts launching a task however as it is not part of the service it doesn't get associated with the load balancer.

My thinking is that I need to create a new service + target group for every PR and then a new rule in the load balancer each time a service is added or removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants