Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow how timing handle the redo/undo event. #1515

Closed
andy840119 opened this issue Aug 19, 2022 · 4 comments
Closed

Follow how timing handle the redo/undo event. #1515

andy840119 opened this issue Aug 19, 2022 · 4 comments
Labels
code quality Improve code quality. documentation Improvements or additions to documentation enhancement New feature or request
Milestone
2022.0827

Comments

@andy840119
Copy link
Member

image
Not really sure how time point interact with control element here.

image
Need a peek look and see how it works because it's very similar to the lyric editor.
@andy840119 andy840119 added enhancement New feature or request code quality Improve code quality. labels Aug 19, 2022
@andy840119
Copy link
Member Author

andy840119 commented Aug 19, 2022 •
edited
Loading

image
See EffectSection.cs
Seems just bind with the control directly.
And make sure not trigger the change handler while binding.

@andy840119 andy840119 added the documentation Improvements or additions to documentation label Aug 19, 2022
@andy840119
Copy link
Member Author

andy840119 commented Aug 19, 2022 •
edited
Loading

Maybe should create base class like LyricPropertySection

Those classes should inherit the base class:

  • TextTagEditSection
  • NoteEditPropertySection
  • SingerEditSection

@andy840119 andy840119 mentioned this issue Aug 20, 2022
Merged
@andy840119
Copy link
Member Author

This issue will not be closed until implement the section part by following this way in the #1444

@andy840119 andy840119 added this to the 2022.0827 milestone Aug 29, 2022
@andy840119
Copy link
Member Author

Section part has been implemented in the #1528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improve code quality. documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
2022.0827
Development

No branches or pull requests
1 participant
@andy840119