Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the display type/property from config into mode. #2177

Closed
andy840119 opened this issue Mar 3, 2024 · 0 comments
Closed

Move the display type/property from config into mode. #2177

andy840119 opened this issue Mar 3, 2024 · 0 comments
Labels
enhancement New feature or request mod Anything about mod.

Comments

@andy840119
Copy link
Member

Inspired from #2176

What's the benefit:

  • Will be easy to make the preset by user. They can display the lyric with romanization if they are not native speaker.
  • The record will be saved in the replay.
  • The logic of lyric display config can be more easy to maintain.
@andy840119 andy840119 added enhancement New feature or request mod Anything about mod. labels Mar 3, 2024
@karaoke-dev karaoke-dev locked and limited conversation to collaborators Mar 17, 2024
@andy840119 andy840119 converted this issue into discussion #2197 Mar 17, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
enhancement New feature or request mod Anything about mod.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andy840119