Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High quality AppIndicator icon #7

Closed
s4nk opened this issue Apr 19, 2015 · 22 comments
Closed

High quality AppIndicator icon #7

s4nk opened this issue Apr 19, 2015 · 22 comments

Comments

@s4nk
Copy link

s4nk commented Apr 19, 2015

It would be nice to replace the current notification area icon with a high quality one (the current icon looks a bit blurry).

Otherwise this app is awesome, thanks a lot!

@stage-two
Copy link

Agreed. Current icon is ugly

@umpirsky
Copy link

+1

@karas84
Copy link
Owner

karas84 commented May 22, 2015

I'd like to, too, but I lack any decent design skill XD. Any help would be appreciated.
For the time being I was thinking of letting the code ask the system for icons and use the default ones only if there are none installed by the user. This way, at least, anyone colud use its own icons.

@umpirsky
Copy link

@karas84 You can google for viber vector logo, I found this one http://seeklogo.com/viber-vector-logo-248447.html. It can be tweaked.

Or, we can even ping @viber to provide one.

@karas84
Copy link
Owner

karas84 commented May 26, 2015

Did some experiments and added icons for dark/light ubuntu theme so they better fit in. Follow the instructions in the README and let me know.

@umpirsky
Copy link

@karas84 Getting:

$ python viberwrapper-indicator.py 
Traceback (most recent call last):
  File "viberwrapper-indicator.py", line 536, in <module>
    viber_icons = ViberIcons.Instance()
  File "viberwrapper-indicator.py", line 140, in Instance
    cls.INSTANCE = ViberIcons()
  File "viberwrapper-indicator.py", line 112, in __init__
    ii_normal = git.lookup_icon('viber-normal', 24, 0).get_filename()
AttributeError: 'NoneType' object has no attribute 'get_filename'

@karas84
Copy link
Owner

karas84 commented May 27, 2015

@umpirsky Thanks, I should have fixed that. Anyhow that also happened because you didn't install the icons. Could you try installing them (instructions are in the readme)? Let me know.

@umpirsky
Copy link

@karas84 I did install them, but I keep getting this error.

selection_037

@karas84
Copy link
Owner

karas84 commented May 27, 2015

@umpirsky Did you also update the caches?

@umpirsky
Copy link

@karas84 Yep.

@karas84
Copy link
Owner

karas84 commented May 27, 2015

@umpirsky I'm just guessing here, try checking the permissions/ownership of the icons so they match the other icons', then update the cache again (with the --force option) and try to change the theme to another one and then go back to the Ambiance one. If that doesn't work either, I'll have to check when I'm back home. Besides, did the previous error go away at least?

@karas84
Copy link
Owner

karas84 commented May 27, 2015

@umpirsky Oh, another thing. Did you install only the dark theme icons or all of the 3 themes? Since gtk only checks (apparently) the hicolor one you actually need to install them all.

@umpirsky
Copy link

@karas84 I guess anyone can read:

selection_038

I tried force cache clear, theme change, no help.

I installed them all, but I noticed that folder structure is not same for hicolor and ubuntu-mono-dark. Is that on purpose?

@karas84
Copy link
Owner

karas84 commented May 27, 2015

@umpirsky Yes it is. I noticed that too. The hicolor icons have a different structure, don't know why. Anyway that's strange, It's working nicely on my system, I'll have to do some experimenting on other clean machines. It would be also useful to have some feedback from other users to confirm this if possible.

@umpirsky
Copy link

@karas84 Thanks for investigating, if you need any more info from my end feel free to ping me.

@s4nk
Copy link
Author

s4nk commented May 27, 2015

thanks @karas84, I'll test it too once I have some time, probably next week

@karas84
Copy link
Owner

karas84 commented May 29, 2015

@umpirsky I just tested the last git on a clean 14.04.2 install. This is what I did: installed dependencies and viber, merged icons, rebuilt caches (for each of the 3 folders and got the "Cache file created successfully" every time). Then I ran the script and the indicator found the right icons immediately, I even tried to change the theme (dark/light/other) and the icons changed accordingly.

@umpirsky
Copy link

@karas84 Must be something related to my system. I will try again. Would be cool to provide install script, that will copy icons and rebuild caches. Thanks.

@karas84
Copy link
Owner

karas84 commented Jun 1, 2015

@umpirsky There is a PPA maintained by @hotice that does this, so for now I'm not planning on that but rather I'll be focusing on bugs and so. For the time being I'm closing this issue. Feel free to post any other problem here if you still cannot manage to get it working.

@karas84 karas84 closed this as completed Jun 1, 2015
@umpirsky
Copy link

umpirsky commented Jun 1, 2015

@karas84 I know, thanks! Keep doing great job.

@umpirsky
Copy link

umpirsky commented Jun 1, 2015

@karas84 Installing ppa:nilarimogard/webupd8 did the trick. Strange, but it works.

@karas84
Copy link
Owner

karas84 commented Jun 1, 2015

Strange indeed. But I'm glad it's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants