Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARC support #27

Closed
Coneko opened this issue Feb 14, 2013 · 3 comments
Closed

ARC support #27

Coneko opened this issue Feb 14, 2013 · 3 comments

Comments

@Coneko
Copy link
Contributor

Coneko commented Feb 14, 2013

The readme specifies ConnectionKit supports OSX 10.6 or later, which means ARC support is possible with weak reference support provided by PLWeakCompatibility.

I'm not requesting this, I just want to ask whether you would be willing to merge it in if I do it myself.

@mikeabdullah
Copy link
Collaborator

The major obstacle to this is that we still support the legacy runtime (32bit on the Mac), which ARC isn't compatible with. We'll drop it at some point and consider ARC then.

So I have to ask, what's your reason for wanting to do this? As a framework, ConnectionKit can be comfortably used in ARC projects. We don't do anything that breaks compatibility with weak references, and have no use for them (currently) internally. There'd be no real benefit from ARC's performance enhancements since CK spends the vast majority of its time sitting waiting for network responses.

All I can see is a slightly smaller, easier-to-maintain codebase. Is there something I've missed?

@Coneko
Copy link
Contributor Author

Coneko commented Feb 15, 2013

You haven't missed anything, those are the only reasons that made me want to do that. Not a big problem though, thanks for the fast reply.

@Coneko Coneko closed this as completed Feb 15, 2013
@mikeabdullah
Copy link
Collaborator

Thanks for the understanding. I'm updating the Readme to note this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants