Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mysterious test suite failures when CONFIG_BLK_DEV_SD isn't enabled in kernel #1376

Closed
rossburton opened this issue Jul 2, 2021 · 1 comment
Closed

Mysterious test suite failures when CONFIG_BLK_DEV_SD isn't enabled in kernel #1376

rossburton opened this issue Jul 2, 2021 · 1 comment

Comments

@rossburton
Copy link
Contributor

If for some reason CONFIG_BLK_DEV_SD isn't enable in the kernel or sd-mod isn't installed, the test suite fails in somewhat mysterious ways:

[ 1163.699863] scsi host0: scsi_debug: version 0190 [20200710]
                 dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
[ 1163.705067] scsi 0:0:0:0: Direct-Access     Linux    scsi_debug       0190 PQ: 0 ANSI: 7
grep: /sys/block/*/device/model: No such file or directory
timeout waiting for scsi_debug device

scsi_debug created the virtual devices, but without the actual SCSI disk support nothing can happen.

I think ts_scsi_debug_init should somehow check that SCSI disk support is enabled, somehow. My SCSI-fu was garbage collected years ago so I can't think of an easy way to do this right now...
@rossburton rossburton changed the title Mysterious test suite failures when CONFIG_BLK_DEV_SD isn't enable in kernel Mysterious test suite failures when CONFIG_BLK_DEV_SD isn't enabled in kernel Jul 2, 2021
@karelzak
Copy link
Collaborator

Oh ... that's crazy. I have a little bit improved the test function where we initialize scsi_debug to avoid "No such file or directory" message and to skip the test if scsi_debug does not work as expected.

karelzak added a commit that referenced this issue Jul 20, 2021
@karelzak
tests: skip if scsi_debug model file is not accessible
4bea482 
* do not print grep(1) info message

* use ts_skip rather than ts_die when scsi_debug is useless

Fixes: #1376
Signed-off-by: Karel Zak <kzak@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rossburton @karelzak