Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger does not support private enterprise sub-tree. #406

Closed
aellisv opened this issue Jan 27, 2017 · 1 comment
Closed

logger does not support private enterprise sub-tree. #406

aellisv opened this issue Jan 27, 2017 · 1 comment

Comments

@aellisv
Copy link

aellisv commented Jan 27, 2017

When specifying the RFC5424 SD-ID, I am prevented to use subtree specifications. For example:
if I use: --sd-id "myname@1234", logger works.
If I use: --sd-id "nyname@1234.123, logger errors out with: logger: invalid structured data ID: 'myname@1234.123'

Adding the subtree is allowed in the RFC5424 spec, sec 7.2.2 as follows.
An enterprise might decide to
use sub-identifiers below its private enterprise number. If sub-
identifiers are used, they MUST be separated by periods and be
represented as decimal numbers. An example for that would be
"32473.1.2".

karelzak added a commit that referenced this issue Jan 28, 2017
The current code supports <name>@<digit> only, but we also need
<name>@<digit>.<digit>[. ...]

RFC5424: 7.2.2 enterpriseId:

 In general, only the IANA-assigned private enterprise number is
 needed (a single number).  An enterprise might decide to use
 sub-identifiers below its private enterprise number.  If sub-
 identifiers are used, they MUST be separated by periods and be
 represented as decimal numbers.  An example for that would be
 "32473.1.2".

Addresses: #406
Signed-off-by: Karel Zak <kzak@redhat.com>
@karelzak
Copy link
Collaborator

Good catch, thanks! Fixed.

karelzak added a commit that referenced this issue Feb 21, 2017
The current code supports <name>@<digit> only, but we also need
<name>@<digit>.<digit>[. ...]

RFC5424: 7.2.2 enterpriseId:

 In general, only the IANA-assigned private enterprise number is
 needed (a single number).  An enterprise might decide to use
 sub-identifiers below its private enterprise number.  If sub-
 identifiers are used, they MUST be separated by periods and be
 represented as decimal numbers.  An example for that would be
 "32473.1.2".

Addresses: #406
Signed-off-by: Karel Zak <kzak@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants