Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script hangs when killing the child process with ^C #686

Closed
mortie opened this issue Sep 4, 2018 · 1 comment
Closed

script hangs when killing the child process with ^C #686

mortie opened this issue Sep 4, 2018 · 1 comment

Comments

@mortie
Copy link

mortie commented Sep 4, 2018

Running script --command 'sleep 5', and hitting ctrl+c before the sleep command exits, causes script to hang indefinitely.

I've confirmed that this happens with a fresh build from this repository (script from util-linux 2.32.371-350f) as well as the version from the Arch repositories (script from util-linux 2.32.1). It also happens an Ubuntu Mate 18.04 VM (script from util-linux 2.31.1). It does not happen in an Ubuntu 16.04 VM (script from util-linux 2.27.1).

I did a git bisect, and this commit introduced the issue: 2e7a922

karelzak added a commit that referenced this issue Sep 5, 2018
The current signalfd handler cares on CLD_EXITED only. It's pretty
insufficient as there is more situations (and codes) when child no
more running.

Addresses: #686
Signed-off-by: Karel Zak <kzak@redhat.com>
@karelzak
Copy link
Collaborator

karelzak commented Sep 5, 2018

Oh, you have also provided patches. I had read only the issue by email and fixed it by another patch. Sorry.

Thanks for you report!

@karelzak karelzak closed this as completed Sep 5, 2018
mtempling added a commit to Ericsson/ove that referenced this issue Jan 10, 2020
karelzak added a commit to redhat-plumbers/util-linux-rhel that referenced this issue Dec 7, 2021
The current signalfd handler cares on CLD_EXITED only. It's pretty
insufficient as there is more situations (and codes) when child no
more running.

Addresses: util-linux/util-linux#686
Upstream: http://github.com/util-linux/util-linux/commit/27afe5016842c22d256ea9f88b598d637ca0df84
Signed-off-by: Karel Zak <kzak@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants