New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util-linux/lib/parse-date.y license #891
Comments
As described the comment, lib/parse-date.y was imported from gnulib And gnulib-tool was used for importing gnulib software My understanding is that the developer can change gnulib software license to LGPL by using gnulib-tool --lgpl option |
No, we do not use parse_date() everywhere and do not link all tools with it. The util-linux license is not GPLv3 at all. We use many licenses and it's per-util, see README.licences. I have moved parse-date.y to hwclock-parse-date.y to make it more obvious that we use the code only in hwclock and not everywhere. So, if we want to be strict and follow the licence headers that hwclock is GPLv3 now. It would be nice if we can re-introduce the file, but with LGPL to make it more usable for us. |
It seems you're right, althougth lib/parse-datetime.y uses GPLv3. I guess the code has been originally exported manually as copy rather than by gnulib-tool ;-( Anyway not sure, how to export it as LGPL
generates all necessary stuff, but foo/gllib/parse-datetime.y is still with GPLv3, bug? |
Maybe I have a solution -- remove all parse-date.y and use parse_timestamp() from lib/timeutils.c. The timeutils.c already covers many date-time formats, it's without problematic license, without dependence on bison, etc. |
I think that following option is correct gnulib-tool --lgpl=2 --create-testdir --dir foo parse-datetimeBR,
…----- Original Message -----
From: Karel Zak <notifications@github.com>
To: karelzak/util-linux <util-linux@noreply.github.com>
Cc: hfuse <hfuse@yahoo.co.jp>; Author <author@noreply.github.com>
Date: 2019/11/7, Thu 18:38
Subject: Re: [karelzak/util-linux] util-linux/lib/parse-date.y license (#891)
It seems you're right,
gnulib/modules/parse-datetime define License: LGPLv2+althougth lib/parse-datetime.y uses GPLv3. I guess the code has been originally exported manually as copy rather than by gnulib-tool ;-(Anyway not sure, how to export it as LGPL gnulib-tool --lgpl=3orGPLv2 --create-testdir --dir foo parse-datetime
generates all necessary stuff, but foo/gllib/parse-datetime.y is still with GPLv3, bug?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
--
布施 博明
|
I think that removing GPLv3 codes is best solution |
... so it works, but the file is still with GPLv3. |
I got same result BTW, you proposed another solution
Could you create hwclocl binary with about file? Regards, |
Well, is hwclock with GPLv3 so big problem? :-) We can use parse_timestamp() from lib/timeutils.c, but it implements only small subset of date-time formats and for some users it may be a regression... We had exec() for date(1) in hwclock originally; this has been replaced by parse-date.y to avoid dependence on date(1) -- so date(1) like time formats are supported for pretty long time and I'm not sure if we want to change it. |
Closing for now. It seems we can alive with GPLv3 hwclock -- at least until someone send patch with better date-time parser ;-) |
The currently used date/time parser (for hwclock --set --date <date>) is gnulib based code with GPLv3. This patch allows to avoid this code and replace it with minimalistic date/time parser. Addresses: #891 Reported-by: Carlos Santos <unixmania@gmail.com> Signed-off-by: Karel Zak <kzak@redhat.com>
The currently used date/time parser (for hwclock --set --date <date>) is gnulib based code with GPLv3. This patch allows to avoid this code and replace it with minimalistic date/time parser. Addresses: #891 Reported-by: Carlos Santos <unixmania@gmail.com> Signed-off-by: Karel Zak <kzak@redhat.com>
I found someone committed following files to the git repository
https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/commit/lib/parse-date.y?id=7088bd88323fa9152ec9fbe4089fe76807445ed3
The lib/parse-date.y is created as GPLv3
Because the library in lib directory is used for creating some util-linux packages, I think that current util-linux license seems GPLv3
But COPYING in top directory said util-linux is GPLv2
https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/COPYING
This confused me
I think that lib/parse-date.y should be LGPLv2.1
The text was updated successfully, but these errors were encountered: