Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: some fixes and some output improvements #244

Closed
wants to merge 7 commits into from

Conversation

rudimeier
Copy link
Contributor

No description provided.

The first BLKRRPART ioctl causes udev events and then second one may
fail, see Discussion
http://comments.gmane.org/gmane.linux.utilities.util-linux-ng/11885

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
This seems to work nowadays and saves 37s.

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
This saves about 400M disk I/O and space.

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Also minor tweaking and fixing output. Now we should get test name
and result always within one non-broken line, which makes watching
or parsing the test log easier.

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Half of the tests have description == name anyway. Some of them
missed to define it. Using the name makes it easier to find the
right file which causes a failed test.

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
@karelzak
Copy link
Collaborator

karelzak commented Jan 5, 2016

Applied, but without:
* tests: remove non-parallel case for result output
* tests: print test name instead of description …

I really want to have human friendly structured non-parallel output where I have information what test is just running (so output in ts_init and ts_init_subtest).

If we want to support easy to parse output than it would be better to add

--quiet --parsable=<filename>

and print there

 <test-filename> : <results>\n

Note that for failed tests we can add full test path to the output (now we use $TS_NS there).

@karelzak karelzak closed this Jan 5, 2016
@karelzak
Copy link
Collaborator

karelzak commented Jan 5, 2016

... and Thanks! (and sorry for delay, I was off-line during Christmas time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants