hardlink: move global variables to control structure #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelzak
reviewed
Apr 29, 2019
misc-utils/hardlink.c
Outdated
| lseek(fd, 0, SEEK_SET); | ||
|
|
||
| for (fsize = st.st_size; fsize > 0; | ||
| fsize -= NIOBUF) { | ||
| char iobuf1[NIOBUF] = { 0 }; | ||
| char iobuf2[NIOBUF] = { 0 }; |
There was a problem hiding this comment.
I'm not sure if move these bufferes to this nested scope is the right thing. Maybe it would be better to keep in global scope as it's used very often.
It would be also nice to use standard BUFSIZ rather than obscure NIOBUF (but, please in separated patch;-)).
This fixes two standards compliancy warnings. hardlink.c:65:7: warning: ISO C forbids zero-size array ‘name’ [-Wpedantic] Reference: https://en.wikipedia.org/wiki/Flexible_array_member Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Well, sort of. Due to use of ctl values in atexit() print_summary() there is need for global control structure. Secondly couple variables can be moved to more restricted scope, namely the PCRE variables are now in main(). Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Reason to retire NIOBUF is that it is obscure local definition, while BUFSIZ is well understood and commonly used constant. Besized sizes of these are not far off, the NIOBUF was 4096 bytes and BUFSIZ tends to be 8192 bytes. Proposed-by: Karel Zak <kzak@redhat.com> Reference: util-linux#783 Signed-off-by: Sami Kerola <kerolasa@iki.fi>
|
Merged and fixed two compiler warnings. Thanks. (Well, we had already -rc1, but hardlink is new in the release and this changes has no impact to functionality and we have regression tests.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usual variable scope tidy up, accompanied with a compiler warning fix.