Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding units to fallocate help message #917

Closed
wants to merge 2 commits into from

Conversation

edneville
Copy link

No description provided.

@karelzak karelzak added the NOT-READY The patch is not ready yet. Need rework. label Jan 2, 2020
@karelzak
Copy link
Collaborator

karelzak commented Jan 2, 2020

I understand the motivation, but I'm not sure about the implementation. First, we have many places in util-linux where is 'size' or 'offset' and where is possible to use size suffixes. It would be nice to keep all the --help outputs consistent.

Years ago someone suggested coreutils-like --help output:

Options:
  ...
  -o, --offset <num>   offset for range operations, in bytes

Where:
  <num> arguments may be followed by the multiplicative suffixes for  
        GiB, TiB, PiB, EiB, ZiB,  and   YiB (the "iB" is optional).

it means after Options add a new section "Where" with necessary details.

@edneville
Copy link
Author

@karelzak, hopefully that's more consistent now.

@karelzak
Copy link
Collaborator

Looks cool, I'll merge it later this week or next. Thanks!

@karelzak karelzak removed the NOT-READY The patch is not ready yet. Need rework. label Jan 28, 2020
karelzak added a commit that referenced this pull request Feb 5, 2020
Let's add "Arguments:" section to the --help output and describe
{K,M,G...}iB suffixes there.

Addresses: #917
Co-Author: ed <ed@s5h.net>
Signed-off-by: Karel Zak <kzak@redhat.com>
@karelzak
Copy link
Collaborator

karelzak commented Feb 5, 2020

I have consolidated it more to keep all in include/c.h only
f1970cc

Thanks!

@karelzak karelzak closed this Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants