Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stray commits from the old svn.ali.as repo #1

Closed
wants to merge 2 commits into from
Closed

Add stray commits from the old svn.ali.as repo #1

wants to merge 2 commits into from

Conversation

jwilk
Copy link

@jwilk jwilk commented Dec 27, 2017

These commits are present in http://svn.ali.as/cpan/trunk/Task-Weaken, but haven't been included in this repo.

@karenetheridge
Copy link
Owner

How are you viewing those commits?

@jwilk
Copy link
Author

jwilk commented Dec 28, 2017

$ svn checkout http://svn.ali.as/cpan/trunk/Task-Weaken
A    Task-Weaken/t
A    Task-Weaken/t/01_compile.t
A    Task-Weaken/t/02_weaken.t
A    Task-Weaken/lib
A    Task-Weaken/lib/Task
A    Task-Weaken/lib/Task/Weaken.pm
A    Task-Weaken/Makefile.PL
A    Task-Weaken/Changes
Checked out revision 16019.

$ cd Task-Weaken/

$ svn log --limit 2
------------------------------------------------------------------------
r16015 | chorny@cpan.org | 2015-06-06 10:05:06 +0200 (Sat, 06 Jun 2015) | 1 line

Require version 1.24 - it has no pure-perl version
------------------------------------------------------------------------
r16014 | chorny@cpan.org | 2015-05-30 23:19:46 +0200 (Sat, 30 May 2015) | 1 line

weak references were added in perl 5.6.0.
------------------------------------------------------------------------

$ svn diff -c r16014
Index: Makefile.PL
===================================================================
--- Makefile.PL (revision 16013)
+++ Makefile.PL (revision 16014)
@@ -79,9 +79,7 @@
                return;
        }
 
-       my $latest_scalar_util = 1.21; #does not support 5.5, but weak references were introduced in 5.6
-       $latest_scalar_util = 1.19 if $] < 5.006;
-       # will not work of course - CPAN automatically installs only latest version
+       my $latest_scalar_util = 1.21;
...

$ svn diff -c r16015
Index: Makefile.PL
===================================================================
--- Makefile.PL (revision 16014)
+++ Makefile.PL (revision 16015)
@@ -57,7 +57,7 @@
        };
        if ( $@ ) {
                # Scalar::Util not installed (really old Perl?)
-               requires 'Scalar::Util' => '1.14';
+               requires 'Scalar::Util' => '1.24';
...

@karenetheridge
Copy link
Owner

thanks, cherry-picked and released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants