Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with dndm in mass_function #2

Open
GoogleCodeExporter opened this issue Jan 27, 2016 · 2 comments
Open

Issue with dndm in mass_function #2

GoogleCodeExporter opened this issue Jan 27, 2016 · 2 comments

Comments

@GoogleCodeExporter
Copy link

The code doesn't properly reflect redshift dependance in dndm within 
mass_function.py, High mass halos have higher values of dndm at higher 
redshifts than lower redshifts according to this code. This is not correct.

See the below code: 

sample = numpy.logspace(11,16,10)
z = 0.5
cosmo = cosmology.SingleEpoch(redshift=z, cosmo_dict=cosmo_dict, with_bao=False)
cosmo_0 = cosmology.SingleEpoch(redshift=0, cosmo_dict=cosmo_dict, 
with_bao=False)
halo = mass_function.MassFunction(redshift=z, cosmo_single_epoch=cosmo, 
halo_dict=halo_dict)
halo_0 = mass_function.MassFunction(redshift=0, cosmo_single_epoch=cosmo_0, 
halo_dict=halo_dict)
#def main(z, Mass, halo_dict=halo_dict, cosmo_dict = cosmo_dict):
for i in sample:
     print i, halo.dndm(i), halo_0.dndm(i)

output: (mass, redshift_0.5, redshift_0)

100000000000.0 8.61351149916e-13 2.65752396915e-13
359381366380.0 7.58494039016e-14 2.38364618837e-14
1.29154966501e+12 6.59518658828e-15 2.11901506138e-15
4.64158883361e+12 5.57429763919e-16 1.83674899106e-16
1.6681005372e+13 4.44080639285e-17 1.50020001669e-17
5.99484250319e+13 3.12979437432e-18 1.06969035187e-18
2.15443469003e+14 1.70217578332e-19 5.59243701388e-20
7.74263682681e+14 5.23716718975e-21 1.40256900589e-21
2.78255940221e+15 4.30629561401e-23 5.63030877376e-24
1e+16 1.35395518901e-26 1.67545857554e-28
benh:chomp-650b1f5371a3 benjaminhorowitz$ python MF_test.py 
100000000000.0 8.61351149916e-13 2.65752396915e-13
359381366380.0 7.58494039016e-14 2.38364618837e-14
1.29154966501e+12 6.59518658828e-15 2.11901506138e-15
4.64158883361e+12 5.57429763919e-16 1.83674899106e-16
1.6681005372e+13 4.44080639285e-17 1.50020001669e-17
5.99484250319e+13 3.12979437432e-18 1.06969035187e-18
2.15443469003e+14 1.70217578332e-19 5.59243701388e-20
7.74263682681e+14 5.23716718975e-21 1.40256900589e-21
2.78255940221e+15 4.30629561401e-23 5.63030877376e-24
1e+16 1.35395518901e-26 1.67545857554e-28


Original issue reported on code.google.com by horowitz...@gmail.com on 27 Jun 2014 at 10:18

@GoogleCodeExporter
Copy link
Author

Original comment by morrison...@gmail.com on 19 Jan 2015 at 2:22

  • Changed state: Accepted

@vvinuv
Copy link

vvinuv commented Mar 10, 2016

Thanks for reporting this GoogleCodeExporter. Could you change the mass function code to return the correct mass function as a function of redshift? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants