Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working properly in Node 14 and newer #1

Closed
apederse opened this issue Mar 5, 2023 · 4 comments
Closed

Not working properly in Node 14 and newer #1

apederse opened this issue Mar 5, 2023 · 4 comments

Comments

@apederse
Copy link

apederse commented Mar 5, 2023

Node 14 introduced a native Blob object and vblob exports global.Blob if present. However, FileReader expects a VBlob class to work properly. Workaround to force use of VBlob is to set global.Blob=null before importing the vblob module.

@apederse
Copy link
Author

apederse commented Mar 7, 2023

Note that if using the more recent Three versions which only has es6 modules the above workaround only works if one forces synchronous import of the vblob module e.g. using const vblob = await import('vblob');

@karikera
Copy link
Owner

karikera commented Mar 8, 2023

Thanks for reporting it.
I fixed it and published the new version (it's 1.1.0).
VFileReader will support Node Blob.

@apederse
Copy link
Author

apederse commented Apr 4, 2023

I can confirm that it works. Btw! The NPM package is updated but it seems that the github repo is not updated with the most recent version?

@karikera
Copy link
Owner

karikera commented Apr 4, 2023

oh, I forgot to push. Thanks for your reply.

@karikera karikera closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants