Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capstone M2: Add tests for items counter #33

Merged
merged 11 commits into from Jul 30, 2022
Merged

Capstone M2: Add tests for items counter #33

merged 11 commits into from Jul 30, 2022

Conversation

karlavdelgadof
Copy link
Owner

Capstone M2: Create tests for items counter 🛠️ 📝 🔢 💯

These are the proposed changes ♻️ for this project ⬇️ :

  • Added test using Jest for mocking the counter function that fetches the items from the API and increases the counter using Jest. ✔️

For more ➕ info about this task

wayungi
wayungi approved these changes Jul 30, 2022
View reviewed changes
Copy link
Collaborator

@wayungi wayungi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 💯 🥇

All can say now is that your code is ready to be merged ✅

@karlavdelgadof karlavdelgadof merged commit 2f3d800 into dev Jul 30, 2022
@wayungi wayungi linked an issue Jul 30, 2022 that may be closed by this pull request
[3pt] - Add tests for items counter - Student A #3
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wayungi wayungi wayungi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3pt] - Add tests for items counter - Student A
2 participants
@karlavdelgadof @wayungi