New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Casptone M3: Mintok Crypto Market App #3
Conversation
Capstone M3: React app setup
Capstone M3: API integration
β Deploy Preview for mintok-kd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @karlavdelgadof ,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! π
Highlights
- Nice commits messagesβοΈ
- Descriptive PR βοΈ
- Good use of GitHub flow βοΈ
- Clean Code βοΈ
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @danielufeli in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Capstone M3: Mintok's Crypto Market App πͺ π
These are the proposed changes β»οΈ for this project β¬οΈ :
You can check the VIDEO DESCRIPTION right here π₯