Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casptone M3: Mintok Crypto Market App #3

Merged
merged 41 commits into from Sep 10, 2022
Merged

Casptone M3: Mintok Crypto Market App #3

merged 41 commits into from Sep 10, 2022

Conversation

karlavdelgadof
Copy link
Owner

@karlavdelgadof karlavdelgadof commented Sep 10, 2022

Capstone M3: Mintok's Crypto Market App πŸͺ™ πŸ“Š

These are the proposed changes ♻️ for this project ⬇️ :

  • Follows Template design main guidelines (Layout, font). πŸ’― 🎨
  • Shows a list of coins and their respective prices βœ”οΈ πŸͺ™ πŸ’Έ
  • The user can filter coins by the name of the coin. βœ”οΈ πŸ‘€ πŸ‘
  • You can navigate through pages by clicking on the coin. βœ”οΈ πŸ–±οΈ πŸ“
  • When the user clicks on the "Go Back" button it redirects them to the home page. βœ”οΈ 🏠
  • All tests are correctly implemented and passed. βœ”οΈ βš™οΈ
  • The project is a single-page application (SPA) built with React and Redux. :atom: βš›οΈ
  • The data retrieved from the API is stored in the Redux store. βœ”οΈ
  • Every page has a unique route within the SPA. βœ”οΈ πŸ“Œ

You can check the VIDEO DESCRIPTION right here πŸŽ₯

@netlify
Copy link

netlify bot commented Sep 10, 2022

βœ… Deploy Preview for mintok-kd ready!

Name Link
πŸ”¨ Latest commit 89039bf
πŸ” Latest deploy log https://app.netlify.com/sites/mintok-kd/deploys/631cd6579646eb0007d9fdf5
😎 Deploy Preview https://deploy-preview-3--mintok-kd.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@danielufeli danielufeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @karlavdelgadof ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

a

Highlights

  • Nice commits messagesβœ”οΈ
  • Descriptive PR βœ”οΈ
  • Good use of GitHub flow βœ”οΈ
  • Clean Code βœ”οΈ

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @danielufeli in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@karlavdelgadof karlavdelgadof merged commit 4cb3029 into main Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants