Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone #2: To-Do list app (Add and remove items) #2 #2

Merged
merged 11 commits into from Jul 8, 2022

Conversation

karlavdelgadof
Copy link
Owner

To Do list: Add and remove items πŸ“ πŸ› οΈ βž• ❌

These are the proposed changes ♻️ for this project ⬇️ :

  • Removed all hardcoded items from the tasks array. βœ”οΈ
  • Created JavaScript modules for the new functionality. πŸ—ƒοΈ
  • Implemented an eventListener for adding a new task (add a new element to the array and localStorage ☁️ ) πŸ‘
    • Set the property index value to the new array length βœ”οΈ
  • Implemented an eventListener for deleting a task (remove an element from the array and the localStorage ☁️ ) :
    • Updated all remaining items' indexes, so they represent the current list order and are unique πŸ’―
  • Added changeDes() function for editing task descriptions. ✏️
  • Changed completed property value in checkBox eventListener βœ”οΈ
  • All changes to the To Do List are saved in local storage. βœ”οΈ πŸ—„οΈ

Copy link

@aimemalaika aimemalaika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @karlavdelgadof,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

133591850-fdcb7dd3-dd7a-4274-81e7-0e59434148f7

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@karlavdelgadof karlavdelgadof merged commit 164c7f3 into main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants