-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: mark does not work if path contains "[" and "]" #553
Comments
Thank you for your detailed bug report! I can reproduce the issue, and it seems to be related to pythons globbing module which interprets the content in square brackets. In @classmethod
def paths_type(cls, globstr: str) -> typing.List[str]:
"""Retrieve list of paths matching the globstr passed."""
print(escape_glob(globstr))
paths = glob.glob(os.path.expanduser(escape_glob(globstr)), recursive=True)
print(paths)
if not paths:
raise ArgumentError(f"No paths matching '{globstr}'")
return paths and clearly the brackets are not escaped properly. While we could just use Would you like to take a look into this? |
Yes, of course, with this I can try to fix it. Thanks. |
Another case: |
It seems that an image can not be marked (with the
mark
command or by pressingm
) if the path contains both, an opening and a closing square bracket.Some examples where marking an image doesn't work ...
and where it works as usual
I've also tested the same paths with round and curly brackets. I observed no issues in these cases.
I can try to fix the issue and submit a PR if somebody can give me a hint where to start.
The text was updated successfully, but these errors were encountered: