Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vimiv-qt-git AUR package to reflect Qt6 support #687

Open
karlch opened this issue Aug 15, 2023 · 2 comments
Open

Update vimiv-qt-git AUR package to reflect Qt6 support #687

karlch opened this issue Aug 15, 2023 · 2 comments
Labels
not-code No coding skills required

Comments

@karlch
Copy link
Owner

karlch commented Aug 15, 2023

Currently, the vimiv-qt-git AUR package hard depends on (Py)Qt5. This is no longer the case.

Instead, we should require one of PyQt5 / PyQt6, which will pull the corresponding Qt version as dependency in case not installed. In the future, this should extend to PySide6.

In addition, the optional dependencies (qt5-svg and qt5-imageformats) must be extended to Qt6, possibly ensuring consistency?

Needs some checking how others do this.

@karlch karlch added the not-code No coding skills required label Aug 15, 2023
@xlucn
Copy link
Contributor

xlucn commented Dec 15, 2023

Probably very hacky? For one similar case, I found an old post.

If we look at qutebrowser, the repo package changed to qt6 dependency as soon as qt6 was supported alongside qt5 (Edit: with the former as default and the latter as fallback).

So I guess it's about priority. You decide which version is the default, and make the AUR package depend on that.

@karlch
Copy link
Owner Author

karlch commented Dec 17, 2023

Thanks a lot for your input! 😊

I guess this is the way to go (like qutebrowser), a bit sad that there is nothing along oneof = "python-pyqt5 python-pyqt6".

I think it would make sense to update both AUR packages (git and regular) once the next version is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-code No coding skills required
Projects
None yet
Development

No branches or pull requests

2 participants