Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including module breaks <ui-view> rendering #1

Closed
Mattnmoore opened this issue Mar 5, 2016 · 11 comments
Closed

Including module breaks <ui-view> rendering #1

Mattnmoore opened this issue Mar 5, 2016 · 11 comments
Labels

Comments

@Mattnmoore
Copy link

When I include the module, all of my states stop rendering their templates. There are no errors in the console either.

angular.module('app.core', ['ngCookies', 'ui.router', 'ui.router.middleware']);
@karlhepler
Copy link
Owner

Have you defined any middleware and passed them into your routes?

@Mattnmoore
Copy link
Author

Yeah I defined a simple middleware that just calls this.next(); and still nothing. But even so, should it stop rendering all routes just by including the module?

@karlhepler
Copy link
Owner

It shouldn't. I'll take a look and try to see what's going on.

@karlhepler
Copy link
Owner

I'm thinking it might be the minified version causing problems - it's the main file referenced in package.json & bower.json. I'm noticing an issue on my end when I use it as well. Please give the non-minified version a try and I'll see if I can stamp out this issue.

@karlhepler
Copy link
Owner

Matt - I did some work, hoping to resolve this issue... that being said - I wasn't able to replicate the exact issue. I'm hoping it's fixed, but if not, would you mind sharing your source code with me so I can track it down?

@Mattnmoore
Copy link
Author

I will try including the non-minified version tonight when I get home from work. If that doesn't work I'll share my code. Thanks for your help! I love the idea of using middleware like this in my Angular app.

@karlhepler
Copy link
Owner

I just threw some code up on plnkr and referenced with links in the readme under the configuration and examples section. I'm using the latest minified code in plnkr and it's working there. I'll stand by - just let me know how it's working on your end, but I think the issue is cleared up.

@karlhepler
Copy link
Owner

Haven't heard anything in a bit - assuming fixed on your end. I'm going to go ahead and close the issue, and will re-open if necessary.

@RogerQuiros
Copy link

Same issue, doesn't work at all, i have nothing fancy, just included the module, and made the basic config.

@karlhepler karlhepler reopened this May 25, 2016
@karlhepler
Copy link
Owner

@Rocker506 - Would you mind attaching a zip of a simple project that isn't working? I'm having trouble recreating the issue on my end - it would be helpful to start with something that I know is failing.

@karlhepler karlhepler added the bug label May 25, 2016
@karlhepler
Copy link
Owner

Hey guys - I the issue and hopefully fixed it. I'm currently using it in a project I'm developing, so I'll be testing it as I work. For now, it seems to be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@karlhepler @Mattnmoore @RogerQuiros and others