Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite redirect with Safari and very long URLs since kh21.7 #440

Closed
pteich opened this issue Nov 17, 2023 · 0 comments
Closed

Infinite redirect with Safari and very long URLs since kh21.7 #440

pteich opened this issue Nov 17, 2023 · 0 comments

Comments

@pteich
Copy link

pteich commented Nov 17, 2023

After adding the redirect changes for Safari with kh21.7 accessing mounts with very long URL params leads to infinite redirects and finally breaks.

In the example below you can see that parts of the URL get truncated at the end:

http --headers GET "http://localhost:8000/atsw-bigfm-aac-128-6355201?sABC=6557q0ns%231%230328oq02pq7n4n4p9515onpsr2p04s17%23ubzrcntr&mode=preroll&aw_0_1st.skey=1700253727&cb=261686703&aw_0_req.userConsentV2=CP1YsIAP1YsIAAFADBDEAbEsAP_gAEPgAAYgIxBFRCpdTWFAMXg1ANsgGYAE1sARIEQQABCAAyAFABOA8IQAgQEAMAQAAAACAQAAoRIBAAAEAABEBACAAAAEAAHkAAAAgAEIIABAAAEQAgBAAAgAAAAAEAAIAAAREwQAmACAIcKEBEAAhIAACAAAAAAAAACFAgMACEAYAAIAAAIAAoBAAgJEMAIAAAEAAQQ5AKAFC4gAKIAJAKAIIAEAAgrAAiAAAAAAEABAAAACABwAgAIgIEAAAAAAAAAgABQgACAAAAAACIAAAAAAAAACAAAAAAAAAQAACAAAAAgAAAABAAAAAAAAAAAAAAAAgBAgCgQAAEAIAAAABAEAAAAAACAAEAAAAAIAAQAAAAAAAABACAAAQIYAQBA0AGAAIIxCIAMAAQRiFQAYAAgjEMgAwABBGIAA.YAAAAAAAAAAA&aw_0_1st.playerid=bigfm_web&aw_0_1st.1plusxAudience=2,2j,2k,2l&gfksui=170025372903417A4CD43E358EDBF0E1353F8CFA2E8BD85D5D567C86&listenerid=0328bd02cd7a4a4c9515bacfe2c04f17&metaid=0328bd02cd7a4a4c9515bacfe2c04f17&amsparams=playerid:homepage;skey:1700253871" icy-metadata:1 User-Agent:'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit
/605.1.15 (KHTML, like Gecko) Version/16.3 Safari/605.1.15'
HTTP/1.0 302 Found
Connection: Close
Content-Length: 0
Content-Type: text/html
Date: Fri, 17 Nov 2023 21:50:53 GMT
Location: http://localhost:8000/atsw-bigfm-aac-128-6355201?sABC=6557q0ns%231%230328oq02pq7n4n4p9515onpsr2p04s17%23ubzrcntr&mode=preroll&aw_0_1st.skey=1700253727&cb=261686703&aw_0_req.userConsentV2=CP1YsIAP1YsIAAFADBDEAbEsAP_gAEPgAAYgIxBFRCpdTWFAMXg1ANsgGYAE1sARIEQQABCAAyAFABOA8IQAgQEAMAQAAAACAQAAoRIBAAAEAABEBACAAAAEAAHkAAAAgAEIIABAAAEQAgBAAAgAAAAAEAAIAAAREwQAmACAIcKEBEAAhIAACAAAAAAAAACFAgMACEAYAAIAAAIAAoBAAgJEMAIAAAEAAQQ5AKAFC4gAKIAJAKAIIAEAAgrAAiAAAAAAEABAAAACABwAgAIgIEAAAAAAAAAgABQgACAAAAAACIAAAAAAAAACAAAAAAAAAQAACAAAAAgAAAABAAAAAAAAAAAAAAAAgBAgCgQAAEAIAAAABAEA

I suspect the changes here: 4addd45#diff-8cd16d58009c14bba46f654ee9700f64f9da67ad24ff39b38b2b8130d7e4956aR382

Maybe the params array is way to small with 512 Bytes?

char params [512];

Unfortunately, in times of user consent strings URLs tend to grow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant