Clone PDU

[carlocorradini]

We need a method/mechanism to clone the PDU:

1. From the generic Header:
   • If Header is "pure" simply return a copy of the Header
   • If Header is the base class of a specialized PDU, clone the whole chain and return a copy of the Header (it can be casted to the correct PDU)
2. From a specialized PDU, simply create a copy of the PDU (clone the whole chain)

@karljj1 I don't know if this is already possible but it's super useful (especially in my use-case)

[karljj1]

You could just call Encode and Decode using the PDU_Factory although it's more work than a straight copy.

[carlocorradini]

@karljj1 Can we try to implement this

What do you think?

[karljj1]

@karljj1 Can we try to implement this

What do you think?

This would involve adding a clone method to every PDU and DataType? It should be fine, just quite a bit of work ;)

[carlocorradini]

See https://github.com/CppCodeReviewers/Covariant-Return-Types-and-Smart-Pointers

This is mind blowing

[karljj1]

Looks interesting. I did avoid using some of the newer c++ features because I know some of the users of kdis were running it on a 20 year old toaster, but it may be time to embrace them 😄

[carlocorradini]

With the refactor we've set the minimum C++ standard as 11.
Therefore, we should be good with this one

[karljj1]

We should probably get rid of my old smart pointer then, if you haven't already 😄

[carlocorradini]

Done in the previous PR

[carlocorradini]

@karljj1 It's correct that Reliability_Header does not extend Header? Am I missing somethig? Thanks

[karljj1]

Yes Reliability header is only for PDU that support it, the PDU tend to be in a special reliable category. So instead we use multiple inheritance to add it in when needed.