Dead Reckoning Other Parameters

[DA5H8Y]

May I suggest that the two standard Dead Reckoning Other Parameters field formats are implemented as classes. This could use the methodologies used within the rest of the PDUs to convert from KDataStreams to the specific PDU structures.

The current SetQuatAxis and GetQuatAxis functions aren't implemented correctly as the storage of the Quaternion vector starts at memory location zero of the 15 octet array rather than at octet 4 of the array.

I've started an example class below.

class DrpParameters
{
protected:
KUINT8 m_uiDeadReckoningParameterType;
KOCTET m_Params[14];

public:
static const KUINT16 DEAD_RECKONING_OTHER_PARAMETER_SIZE = 15;
DrpParameters();
DrpParameters( KDataStream & stream);
DrpParameters(KDIS::DATA_TYPE::ENUMS::DeadReckoningParameters DRP, const KOCTECT & params);
virtual ~DrpParameters();

void SetDeadReckoningParemeter(KDIS::DATA_TYPE::ENUMS::DeadReckoningParameters DRP);
KDIS::DATA_TYPE::ENUMS::DeadReckoningParameters DRP GetDeadRockoningParameter() const;
virtual KString GetAsString() const;
virtual void Decode( KDataStream & stream ) ;
virtual KDataStream Encode() const;
virtual void Encode( KDataStream & stream ) const;
KBOOL operator == ( const DrpParameters& Value ) const;
KBOOL operator != ( const DrpParameters& Value ) const;

}

class LocalEulerAnglesDrpParameters : public DrpParameters
{
protected:
KUINT16 m_uiPadding; // unused
KFLOAT m_LocalYaw;
KFLOAT m_LocalPitch;
KFLOAT m_LocalRoll;

public:
LocalEulerAnglesDrpParameters ();
LocalEulerAnglesDrpParameters ( KDataStream & stream);
LocalEulerAnglesDrpParameters (KDIS::DATA_TYPE::ENUMS::DeadReckoningParameters DRP, const Vector & eulerAngles);
virtual ~LocalEulerAnglesDrpParameters ();

void SetEulerAngles( const Vector & LEA );
const Vector & GetEulerAngles() const;
Vector & GetEulerAngles();

virtual KString GetAsString() const;
virtual void Decode( KDataStream & stream ) ;
virtual KDataStream Encode() const;
virtual void Encode( KDataStream & stream ) const;
KBOOL operator == ( const LocalEulerAnglesDrpParameters & Value ) const;
KBOOL operator != ( const LocalEulerAnglesDrpParameters & Value ) const;
}

class QuarternionDrpParameters : public DrpParameters
{
protected:
KUINT16 m_uiQuartU0;
KFLOAT m_QuartUX;
KFLOAT m_QuartUY;
KFLOAT m_QuartUZ;

public:
QuarternionDrpParameters ();
QuarternionDrpParameters ( KDataStream & stream);
QuarternionDrpParameters (KDIS::DATA_TYPE::ENUMS::DeadReckoningParameters DRP, const Quart & Quart); // New Quaternion Type?
virtual ~QuarternionDrpParameters ();

void SetQuarternions( const QUART & Quart );
const Quart & GetQuarternions() const;
Quart & GetQuarternions();

virtual KString GetAsString() const;
virtual void Decode( KDataStream & stream ) ;
virtual KDataStream Encode() const;
virtual void Encode( KDataStream & stream ) const;
KBOOL operator == ( const QuarternionDrpParameters & Value ) const;
KBOOL operator != ( const QuarternionDrpParameters & Value ) const;
}

[carlocorradini]

@DA5H8Y Can you create a PR?

[DA5H8Y]

@carlocorradini I can it might take me a while however as I'm busy.

[carlocorradini]

@DA5H8Y No problem
Take as much time as necessary 🤗🥳

[carlocorradini]

@DA5H8Y Note that the repo structure has been updated.
I suggest you update with the new version and then start working on the patch 👍🥳