Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image improvements #60

Closed
6 of 7 tasks
karlomikus opened this issue Jan 28, 2023 · 8 comments · Fixed by #73
Closed
6 of 7 tasks

Docker image improvements #60

karlomikus opened this issue Jan 28, 2023 · 8 comments · Fixed by #73
Assignees
Labels

Comments

@karlomikus
Copy link
Owner

karlomikus commented Jan 28, 2023

  • Switch to PHP-FPM image variant
  • Include meilisearch instance in base BA image
  • Add empty volume for BA data
    • Move uploads folder and db file to this folder
  • Add nginx as default reverse proxy
  • Add services by path in a another nginx instance
    • /search for meilisearch, /bar for api
    • Update code to handle this changes
  • Use nginx to serve static files for salt-rim
  • [Optional] Create a single container image based on alpine

This should hopefully simplify deployment.

Related issues: #12 #26 #37 #50 #59

bar-assistant/docker#2

@karlomikus karlomikus added the feat New feature or request label Jan 28, 2023
@karlomikus karlomikus self-assigned this Jan 28, 2023
@zhdenny
Copy link

zhdenny commented Jan 28, 2023

This sounds like a pretty big update/upgrade for docker users.

Could you include any special upgrade instructions when this is released. Like path changes or docker compose changes etc.

Awesome work man!

@karlomikus
Copy link
Owner Author

Before all this I will iron out application backup and import features.
Ideally this will not be a huge change to user's docker settings but we will see :D

@kavemang

This comment was marked as off-topic.

@zhdenny
Copy link

zhdenny commented Jan 28, 2023

Open a separate issue and provide your full docker compose file.

@damian-w
Copy link

+1 for the suggestion to a merge everything into a single container image based on alpine

@karlomikus
Copy link
Owner Author

+1 for the suggestion to a merge everything into a single container image based on alpine

This was something I planned to do from the start but it kinda goes against the whole containerization principle. But I will definitely simplify redis and meilisearch dependencies.

@tscibilia
Copy link

I tried the new docker info you referenced in this PR bar-assistant/docker#2 but it's still not connecting to the bar assistant server. I'm seeing a "Status: Not available" on the frontend login screen

@karlomikus
Copy link
Owner Author

I tried the new docker info you referenced in this PR bar-assistant/docker#2 but it's still not connecting to the bar assistant server. I'm seeing a "Status: Not available" on the frontend login screen

That is still work in progress, and I still haven't released any images for that branch.

But that should be done by the end of this month

@karlomikus karlomikus linked a pull request Feb 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants