License and thoughts

[livibetter]

I noticed a few things and I'd like to contribute, however, there is no license and I don't like to touch code without written open source license.

@karlstav would you license C.A.V.A? If yes, @anko and @CelestialWalrus do you agree on the license?

---

Here is a list I might do:

• no consistent coding style, and issues like \t and space mixed in indentations and trailing whitespace, etc.

  This one has to be done first, or more inconsistence would be made.

• makefile, use canned recipe and turn on -Wall and -Wextra, etc.

• warnings like the following and things popping out after turning on warnings:

  cava.c:586:40: warning: universal character names are only valid in C++ and C99 [enabled by default]
                                   printf("\u2588");
  

  It's just warning, although cava works fine, but I think this should be dealt with properly.

  I think this need @karlstav to decide the direction, either -std=c99 or print out UTF8-encoded? I am not sure since I have never dealt with the Unicode, not really a C coder. (And Use ncurses instead of printing a lot? #4 related or helped?)

  If taking C99 route, usleep might need to be replaced with nanosleep or there would be another warning.

[ghost]

@livibetter @karlstav I'd suggest using MIT/X11 license. I'd agree on anything open source. (GPL, MIT, WTFPL).

[anko]

My contributions have been minimal, but if it counts for anything, I like MIT (or ISC) for their simplicity. Also OK with other open source.

[karlstav]

@livibetter thanks for all the input, I am verry pleased that you want to contribute! I have now licensed it under MIT. It seemed the simplest although I am a big fan of the GNU GPL as well.

Coding style is a problem for me, since i don't really know any. I tend to simply ramble down the code. Maybe I should read up on that.

I remember trying to use C99, but it produced a lot of other warnings and indeed an error. I think getting rid of the warnings in some other way is better.

[livibetter]

@karlstav sounds like you want to take on coding style, if so, good, it's better you to decide what kind of style you want for cava.

I will close this issue and hold on for a while to see what you decide to do.