Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Nuba.Finance.Google to Trady.Importer #4

Closed
karlwancl opened this issue Jun 27, 2017 · 3 comments
Closed

Integrate Nuba.Finance.Google to Trady.Importer #4

karlwancl opened this issue Jun 27, 2017 · 3 comments
Assignees
Projects

Comments

@karlwancl
Copy link
Owner

Refer to: #2

Nuba.Finance.Google: https://github.com/nubasoftware/Nuba.Finance.Google

@karlwancl karlwancl created this issue from a note in v2.1 (TODO) Jun 27, 2017
@karlwancl karlwancl self-assigned this Jun 27, 2017
@fernaramburu
Copy link
Contributor

@lppkarl said "For the importer, it's architecturally well to divide different importers into different pieces, as a make-all-things-atomic developer, I can't agree more on this. But I wonder if it would be too small for each importer to have its own package. I mean the importer itself only implements a single method, and it's just an adapter to other stock data importing library, e.g. The Trady.Importer.Quandl is referencing Quandl.NET (also 1 of my project). It would have some overhead for users to install some/all of them which may not worth the division. However, we can do this by seperating them into 2 sets, one is Trady.Importer.dll for all bundled, the other is Trady.Importer.xxx.dll for different importers. Is it OK for you for this approach?"

Fully agree with you! Architecture would be the enemy of being simple :)
Let's do it as you suggested.

@karlwancl
Copy link
Owner Author

karlwancl commented Jul 1, 2017

@fernaramburu , ok, i would work on the Trady.Importer.dll first & the separated dlls later :)

@karlwancl karlwancl moved this from TODO to In Progress in v2.1 Jul 4, 2017
karlwancl pushed a commit that referenced this issue Jul 6, 2017
 into google_finance

* 'google_finance' of https://github.com/salmonthinlion/Trady:
  Fixes #4, divide importers to different projects
  #4, Complete integrating Nuba.Finance.Google into Trady.Importer
@karlwancl
Copy link
Owner Author

The importers have been completed, waiting for merging to "master" when #3 is done

@karlwancl karlwancl moved this from In Progress to Completed in v2.1 Jul 6, 2017
karlwancl pushed a commit that referenced this issue Aug 18, 2017
* google_finance:
  #3, updated core, importer & analysis.strategy from IList to IEnumerable
  Updated *.csproj
  Fix redundant ImportByGoogleFinance test method after a rebase
  Fixes #4, divide importers to different projects
  #4, Complete integrating Nuba.Finance.Google into Trady.Importer
  Fixes #4, divide importers to different projects
  #4, Complete integrating Nuba.Finance.Google into Trady.Importer

# Conflicts:
#	Trady.Analysis/Helper/Misc.cs
#	Trady.Analysis/Strategy/AnalyzableLocator.cs
#	Trady.Analysis/Strategy/IndexedCandle.cs
#	Trady.Analysis/Strategy/Portfolio.cs
#	Trady.Analysis/Strategy/Result.cs
#	Trady.Analysis/Strategy/Transaction.cs
#	Trady.Core/Trady.Core.csproj
#	Trady.Importer/Trady.Importer.csproj
#	Trady.Test/IndicatorTest.cs
karlwancl pushed a commit that referenced this issue Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2.1
Completed
Development

No branches or pull requests

2 participants