feat: add device option

karma-runner · Aug 10, 2013 · 695a13f · 695a13f
1 parent a951d9d
commit 695a13f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -45,10 +45,16 @@ module.exports = function(config) {
         browser: 'firefox',
         os: 'mac',
         version: '21.0'
+      },
+      bs_iphone5: {
+        base: 'BrowserStack',
+        device: 'iPhone 5',
+        os: 'ios',
+        version: '6.0'
       }
     },
 
-    browsers: ['bs_firefox_mac']
+    browsers: ['bs_firefox_mac', 'bs_iphone5']
   });
 };
 ```
@@ -60,6 +66,7 @@ module.exports = function(config) {
 
 
 ### Per browser options
+- `device` name of the device
 - `browser` name of the browser
 - `version` version of the browser
 - `os` which platform ?

diff --git a/index.js b/index.js
@@ -72,7 +72,7 @@ var BrowserStackBrowser = function(id, emitter, args, logger,
   var workerId = null;
   var captured = false;
   var log = logger.create('launcher.browserstack');
-  var browserName = args.browser + (args.version ? ' ' + args.version : '') +
+  var browserName = (args.browser || args.device) + (args.version ? ' ' + args.version : '') +
                     (args.os ? ' (' + args.os + ')' : '') + ' on BrowserStack';
 
   this.id = id;
@@ -82,6 +82,7 @@ var BrowserStackBrowser = function(id, emitter, args, logger,
     // TODO(vojta): handle non os/browser/version
     var settings = {
       os: args.os,
+      device: args.device,
       browser: args.browser,
       version: args.version || 'latest',
       url: url + '?id=' + id