Skip to content

Commit

Permalink
feat: allow passing custom flags
Browse files Browse the repository at this point in the history
  • Loading branch information
vojtajina committed Jun 24, 2013
1 parent b32075d commit 4ebc769
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
17 changes: 9 additions & 8 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
var ChromeBrowser = function(baseBrowserDecorator) {
var ChromeBrowser = function(baseBrowserDecorator, args) {
baseBrowserDecorator(this);

var flags = args.flags || [];

this._getOptions = function(url) {
// Chrome CLI options
// http://peter.sh/experiments/chromium-command-line-switches/
Expand All @@ -9,9 +11,8 @@ var ChromeBrowser = function(baseBrowserDecorator) {
'--no-default-browser-check',
'--no-first-run',
'--disable-default-apps',
'--start-maximized',
url
];
'--start-maximized'
].concat(flags, [url]);
};
};

Expand All @@ -26,11 +27,11 @@ ChromeBrowser.prototype = {
ENV_CMD: 'CHROME_BIN'
};

ChromeBrowser.$inject = ['baseBrowserDecorator'];
ChromeBrowser.$inject = ['baseBrowserDecorator', 'args'];


var ChromeCanaryBrowser = function(baseBrowserDecorator) {
ChromeBrowser.call(this, baseBrowserDecorator);
var ChromeCanaryBrowser = function(baseBrowserDecorator, args) {
ChromeBrowser.call(this, baseBrowserDecorator, args);

var parentOptions = this._getOptions;
this._getOptions = function(url) {
Expand All @@ -50,7 +51,7 @@ ChromeCanaryBrowser.prototype = {
ENV_CMD: 'CHROME_CANARY_BIN'
};

ChromeCanaryBrowser.$inject = ['baseBrowserDecorator'];
ChromeCanaryBrowser.$inject = ['baseBrowserDecorator', 'args'];


// PUBLISH DI MODULE
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "Vojta Jina <vojta.jina@gmail.com>",
"dependencies": {},
"peerDependencies": {
"karma": "~0.9"
"karma": "~0.9.3"
},
"license": "MIT"
}

0 comments on commit 4ebc769

Please sign in to comment.