Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version #121

Closed
birtles opened this issue Oct 12, 2020 · 4 comments
Closed

Release new version #121

birtles opened this issue Oct 12, 2020 · 4 comments

Comments

@birtles
Copy link
Collaborator

birtles commented Oct 12, 2020

@johnjbarton Would it be possible to release a new version?

In particular it would be good to ship #114 and #116 since they seem to be tripping people up.

Note, however, that it is a breaking change since when we bumped standard-version to 8.0.1 in #117 I had to bump the minimum Node version to version 10.

@johnjbarton
Copy link
Contributor

@birtles Let's set this repo to use semantic-release. We've had great luck with it on other karma repos.

This involves a PR to add the modules and connect them to build. It involves adopting a format (which is linted) for commit messages that the release tool understands. (It may involve some admin I need to do). Then your merges will automatically release.

"@semantic-release/changelog": "5.0.0",
"@semantic-release/git": "9.0.0",
"@semantic-release/npm": "7.0.4",
"husky": "4.2.3",
  • Add the husky (linter) config to package.json:
  "husky": {
    "hooks": {
      "commit-msg": "commitlint -E HUSKY_GIT_PARAMS"
    }
  },

If you send the PR for me to review we can get it set up.

@birtles
Copy link
Collaborator Author

birtles commented Oct 20, 2020

Great, thank you!

I've started #122 for this.

@johnjbarton
Copy link
Contributor

Ok it look worked, thanks!

@birtles
Copy link
Collaborator Author

birtles commented Oct 20, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants