Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better icons for test results #12

Open
vojtajina opened this issue Aug 16, 2013 · 1 comment
Open

Better icons for test results #12

vojtajina opened this issue Aug 16, 2013 · 1 comment

Comments

@vojtajina
Copy link
Contributor

The tree view on the left, I think just simple circles with a little border would be better:

  • passed test - green (without "OK")
  • failed test - red
  • skipped test - gray

The colors and style are just super quick suggestion, feel free to find something better...

Of course, this is not that high priority...

@segrey
Copy link
Contributor

segrey commented Aug 19, 2013

To render test tree Karma integration uses common test runner API.
This API is used by other frameworks/languages across all IntelliJ IDEs.
It gives UI consistency of integrations for different test runners.

So this issue is about changing icons for all test runner integrations, not only Karma test runner.

Could you please clarify appearance of the suggested icons:

  • Are the suggested icons filled or unfilled?
  • Should icon for failed test contain exclamation mark inside it or not?
  • It would be very convenient if you could attach the suggested icons to the issue (drafts would also be nice).

I'll pass your feedback to our UI designers as soon as the issue is clarified.
Or you can file an issue directly in the http://youtrack.jetbrains.com/issues/WEB#newissue=yes .
In that case, you'll communicate directly with a person who is responsible for our icons.

JFYI, WebStorm has two types of failed tests:

  • tests that failed as a result of failed assertion (yellow circle with an exclamation mark);
  • tests that failed as a result of thrown exception (red circle with an exclamation mark).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants