Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redundant Jump to Source and Show Source context menus #17

Open
IgorMinar opened this issue Aug 24, 2013 · 3 comments
Open

redundant Jump to Source and Show Source context menus #17

IgorMinar opened this issue Aug 24, 2013 · 3 comments

Comments

@IgorMinar
Copy link

they both seem to do the same thing... I don't know what they are supposed to do.

@IgorMinar
Copy link
Author

ah... there is a difference, one just shows the source and the other actually moves the caret there.

Why not just getting rid of the two menus and make selection of a test via mouse or keyboard "Show source" and subsequent enter jump to it?

@segrey
Copy link
Contributor

segrey commented Aug 24, 2013

Removing "Jump to Source" menu item will reduce possibility for users to know the keyboard shortcut for this action F4. Let's keep it.
Yep, selecting a test in a test result tree (via mouse or keyboard) shows the source of the test, but doesn't move the caret there.
Pressing Enter on a selected test tree node expands the node. Well, such Enter behavior is common for the whole IDE: it expands tree nodes in all trees.
This action makes sense for suites. It does nothing for specs, because specs have no children.

Suggestion:
It's possible to implement the caret movement to the source if Enter pressed on the leaf tree node (i.e. spec).
If Enter pressed on a tree node with children (i.e. suite), it will still expand the node (no caret movement here).
Is such behavior OK?

@IgorMinar
Copy link
Author

yes. that would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants