Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writing a one report file per browser #8

Closed
wants to merge 3 commits into from

Conversation

janeklb
Copy link
Contributor

@janeklb janeklb commented Sep 30, 2013

Hoping to kill two birds with one stone with this PR (#2 & #4).

One very important thing to note is that this change results in all generated report files to have <testsuite> as their root element, and NOT <testsuites>.

});
};

this.onBrowserComplete = function(browser) {
var suite = suites[browser.id];
var result = browser.lastResult;
var outputFile = outputDir + 'TEST-' + browser.name.replace(/ /g, '_') + '.xml';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove the TEST, just the browser name is fine I think.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure removing 'TEST' do more good here since prefixing the generated report with TEST or TESTS will make the reports useful for SonarQube JavaScript Plugin.

@vojtajina
Copy link
Contributor

@janeklb Can you please rebase this on #karma-0.11 branch?

@vojtajina
Copy link
Contributor

I'm gonna test this with our CI build to see the results...

@janeklb
Copy link
Contributor Author

janeklb commented Nov 23, 2013

@vojtajina will do -- I assume it will need to be tested with karma 0.11 (vs 0.10)?

@vojtajina
Copy link
Contributor

@janeklb Actually, just rebase it on the current master. I merged the karma-0.11 branch into the master and made it back compatible, so now it should work with both Karma 0.10 and 0.11...

@vojtajina
Copy link
Contributor

@janeklb btw, you can just force push to an existing branch and github will update the PR...

@janeklb
Copy link
Contributor Author

janeklb commented Nov 25, 2013

Thanks for the tip. In that case should I leave the current/new PR as is?

@freizl
Copy link

freizl commented Dec 18, 2014

Hi,

What's status of this PR?
Turns out changes were not merged to master.

Thanks.

@monasuncion
Copy link

Hi,

I'm getting problems publishing the created junit report in Sonar. I think it requires <testsuit> to be the root element (Sonar use Surefire format for standard format for JUnit XML output) . Would require this PR to be merge to test if this is the case.

Thank you,
Mon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants