New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
writing a one report file per browser #8
Conversation
}); | ||
}; | ||
|
||
this.onBrowserComplete = function(browser) { | ||
var suite = suites[browser.id]; | ||
var result = browser.lastResult; | ||
var outputFile = outputDir + 'TEST-' + browser.name.replace(/ /g, '_') + '.xml'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove the TEST
, just the browser name is fine I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure removing 'TEST' do more good here since prefixing the generated report with TEST or TESTS will make the reports useful for SonarQube JavaScript Plugin.
@janeklb Can you please rebase this on |
I'm gonna test this with our CI build to see the results... |
@vojtajina will do -- I assume it will need to be tested with karma 0.11 (vs 0.10)? |
@janeklb Actually, just rebase it on the current master. I merged the |
@janeklb btw, you can just force push to an existing branch and github will update the PR... |
Thanks for the tip. In that case should I leave the current/new PR as is? |
Hi, What's status of this PR? Thanks. |
Hi, I'm getting problems publishing the created junit report in Sonar. I think it requires Thank you, |
Hoping to kill two birds with one stone with this PR (#2 & #4).
One very important thing to note is that this change results in all generated report files to have
<testsuite>
as their root element, and NOT<testsuites>
.