fix: report time for skipped tests so that netTime is computed correctly

Closes #141
karma-runner · Apr 12, 2013 · 4f5470d · 4f5470d
1 parent b613c05
commit 4f5470d
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/src/adapter.js b/src/adapter.js
@@ -54,13 +54,15 @@ var createMochaReporterConstructor = function(tc) {
     });
 
     runner.on('test end', function(test) {
+      var skipped = test.pending === true;
+
       var result = {
         id: '',
         description: test.title,
         suite: [],
         success: test.state === 'passed',
-        skipped: test.pending === true,
-        time: test.duration,
+        skipped: skipped,
+        time: skipped ? 0 : test.duration,
         log: test.$errors || []
       };
 

diff --git a/test/adapter.spec.js b/test/adapter.spec.js
@@ -66,6 +66,24 @@ describe('adapter mocha', function() {
       });
 
 
+      it('should report time 0 for skipped tests', function () {
+        spyOn(tc, 'result').andCallFake(function(result) {
+          expect(result.skipped).toBe(true);
+          expect(result.time).toBe(0);
+        });
+
+        var mockMochaResult = {
+          pending: true,
+          parent: {root: true}
+        };
+
+        runner.emit('test', mockMochaResult);
+        runner.emit('test end', mockMochaResult);
+
+        expect(tc.result).toHaveBeenCalled();
+      });
+
+
       it('should report failed result', function() {
         spyOn(tc, 'result').andCallFake(function(result) {
           expect(result.success).toBe(false);