Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No test names are being set, undefined instead #241

Closed
christian-bromann opened this issue Mar 9, 2021 · 8 comments · Fixed by #243
Closed

No test names are being set, undefined instead #241

christian-bromann opened this issue Mar 9, 2021 · 8 comments · Fixed by #243
Assignees
Labels

Comments

@christian-bromann
Copy link
Contributor

It seems like with the latest version of Sauce Launcher all results are being transmitted as undefined, see https://app.saucelabs.com/tests/62eaaf74c9244092b878a6d71074992f

@wswebcreation
Copy link
Collaborator

@christian-bromann ?
Is this with the current demo that is provided or is this with one of the last versions of Karma

@christian-bromann
Copy link
Contributor Author

Must be with one of the last versions. I discovered the error looking at MochaJS jobs and they have defined this package as "karma-sauce-launcher": "^4.3.4", in their package.json which I assume downloads the latest version.

@wswebcreation
Copy link
Collaborator

This might be related to the karma version they are using, the issue doesn't happen when I look at the current tests in this project

@wswebcreation
Copy link
Collaborator

I'll see if I can figure this one out in the coming days

@wswebcreation wswebcreation self-assigned this Mar 9, 2021
@taymoork2
Copy link
Contributor

I created a patch for my setup --> webex/webex-js-sdk#2032
I'm using karma v6 and mocha v8 so I'm unsure if the package version is the actual issue

// node_modules/karma-sauce-launcher/dist/reporter/reporter.js

-        const status = result.success ? '✅' : '❌';
+        const status = result.success ? '✅' : result.skipped ? '➖' : '❌';
         browserData.results.push({
             status: 'info',
-            message: `${status} ${result.fullName}`,
+            message: `${status} ${result.fullName || result.description}`,

@christian-bromann
Copy link
Contributor Author

@taymoork2 would you mind creating a PR?

@taymoork2
Copy link
Contributor

@christian-bromann can do
FYI my patch also changes a console.info to a console.debug since it ends up spamming the console for me, unsure if you'd like me to add this change as well

- log.info(`Check if 'log.json' for browser '${browserName}' has already been stored.`);
+ log.debug(`Check if 'log.json' for browser '${browserName}' has already been stored.`);

@karmarunnerbot
Copy link
Member

🎉 This issue has been resolved in version 4.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants