Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sauce error formatting #39

Closed
wants to merge 1 commit into from
Closed

fix: sauce error formatting #39

wants to merge 1 commit into from

Conversation

ChrisWren
Copy link
Contributor

Closes #38

@vojtajina not sure if data is a valid property of the error object, any idea why this is here?

@pkozlowski-opensource
Copy link
Member

+1 I keep hitting it randomly (mostly with Android browsers). @ChrisWren @vojtajina is there any documentation anywhere on the format of the data we can get back with the error? If not maybe we should print out the message and dump the whole error object as well?

@pkozlowski-opensource
Copy link
Member

@ChrisWren since I haven't had any input regarding the format of sauce errors and there is not much discussion going on in this PR I've decided to push an alternative implementation via 9aed483. I wanted to play it "on the safe side" so we don't loose debugging info.

@ChrisWren
Copy link
Contributor Author

Awesome, great work!

@aymericbeaumet
Copy link
Member

Can the log branch be safely deleted?

@pkozlowski-opensource
Copy link
Member

@aymericbeaumet I think so. It looks like @ChrisWren is not using his own fork but pushing branches to be merged directly to this repo, lol.

@aymericbeaumet
Copy link
Member

I can't blame him I'm doing the same... :) I'm just asking to clean up a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

formatSauceError: err.data not always defined
3 participants