Promote failed if you promote a resource (other kind) with same name before

[wuyingjun-lucky]

What happened:
Promote failed if you promote a resource (other kind) with same name before
What you expected to happen:
promote sucess
How to reproduce it (as minimally and precisely as possible):
Step 1 in member:
kubectl create clusterrole test-0517 --verb=get,list,watch --resource=pods
kubectl create namespace test-0517
Step 2 in karmada
kubectl-karmada --kubeconfig /etc/karmada/karmada-apiserver.config promote clusterrole test-0517 -c cluster37
kubectl-karmada --kubeconfig /etc/karmada/karmada-apiserver.config promote namespace test-0517 -c cluster37
Result

Anything else we need to know?:
@lonelyCZ Should we fix the error in this scenario ?
Environment:

• Karmada version:
• kubectl-karmada or karmadactl version (the result of kubectl-karmada version or karmadactl version):
• Others:

[lonelyCZ]

Thanks for finding it, yes, this is a bug, for cluster scope resource, we could add kind to the name of cpp.

[wuyingjun-lucky]

add

kind + "-" + "name" + "-propagation" ?

[wuyingjun-lucky]

/assign

[lonelyCZ]

kind + "-" + "name" + "-propagation" ?

Good.

[RainbowMango]

After going through this issue, seems the naming rule for PropagationPolicy and ClusterPropagationPolicy might be conflicts.

karmada/pkg/karmadactl/promote.go

Line 474 in 9a62ca1

name := opts.name + "-propagation"

I think we can use the name-<hash> as the policy name. E.g.
For deployment named nginx, the policy name could be "nginx-hash(FederatedKey)".