Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform objects in informer #1866

Closed
1 task done
RainbowMango opened this issue May 23, 2022 · 3 comments · Fixed by #2089
Closed
1 task done

Transform objects in informer #1866

RainbowMango opened this issue May 23, 2022 · 3 comments · Fixed by #2089
Assignees
@dddddai
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@RainbowMango
Copy link
Member

RainbowMango commented May 23, 2022 •
edited
Loading

What would you like to be added:
Adopt SetTransform feature of client-go.

Why is this needed:
Save memory usage for the informers.

References

background: #1858 (comment)
SetTransform feature: kubernetes/kubernetes#107507

Dependencies
@RainbowMango RainbowMango added the kind/feature Categorizes issue or PR as related to a new feature. label May 23, 2022
@RainbowMango RainbowMango mentioned this issue May 23, 2022
Closed
@dddddai
Copy link
Member

dddddai commented May 23, 2022 •
edited
Loading

Transforming pods would prevent users from propagating pods directly, personally I don't think users would do this though... but anyway it's a breaking change, do you think it's ok to ignore it?

@RainbowMango
Copy link
Member Author

Transforming pods would prevent users from propagating pods directly,

Why do you think that? I haven't looked at this feature carefully but seems we can null out unused fields to save ram cost.

@dddddai
Copy link
Member

dddddai commented Jun 1, 2022

/assign

This was referenced Jun 20, 2022
Merged
Merged
@dddddai dddddai mentioned this issue Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dddddai dddddai

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Karmada Release 1.3
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adopt transform func to save memory dddddai/karmada
2 participants
@RainbowMango @dddddai