Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pp/cpp's spreadconstraints are not validated correctly #3231

Closed
whitewindmills opened this issue Mar 2, 2023 · 2 comments · Fixed by #3232
Closed

pp/cpp's spreadconstraints are not validated correctly #3231

whitewindmills opened this issue Mar 2, 2023 · 2 comments · Fixed by #3232
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@whitewindmills
Copy link
Member

What happened:
Error pp/cpp's spreadconstraints can be create and affect the scheduling process.
0880c4c80710fad0c20c

0880c4c80710fad0a20c

What you expected to happen:
minGroups and maxGroup should not be less that zero, and maxGroup should also get default value(I think it should be minGroups)
How to reproduce it (as minimally and precisely as possible):
Create pp or cpp with incorrect minGroups and maxGroup.
Anything else we need to know?:

Environment:

  • Karmada version:
  • kubectl-karmada or karmadactl version (the result of kubectl-karmada version or karmadactl version):
  • Others:
@whitewindmills whitewindmills added the kind/bug Categorizes issue or PR as related to a bug. label Mar 2, 2023
@whitewindmills
Copy link
Member Author

/assign

@RainbowMango
Copy link
Member

Thanks, It makes sense to me. I'll look at #3232 later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants