-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator init operations may need bigger timeout #3935
Comments
/cc @calvin0327 @Poor12 @lonelyCZ |
/kind question |
/remove-kind bug |
Which version of karmadactl we are talking about? I remember we have introduced a flag( -bash-5.0# karmadactl init --help
Install the Karmada control plane in a Kubernetes cluster.
Options:
--wait-component-ready-timeout=120:
Wait for karmada component ready timeout. 0 means wait forever
Usage:
karmadactl init [options]
Use "karmadactl options" for a list of global command-line options (applies to all commands).
Please try with the karmadactl on master. |
its install by operator, not karmadactl |
oh, sorry my bad. |
may we can update to 120s, i think its enough at most situations |
I have experienced similar problems in From a user perspective, it greatly affects the installation experience. This will cause users to dislike our slow installation process, and they may not know that it is actually due to their poor network that the image pulling process is slow. In fact, our installation process is very simple and fast. I tend to separate pulling images from other installation operations, that is, pulling images first before performing other operations. And, user will get a install log like: start pulling images:
start pull image karmada-xxxx ....... done
start pull image karmada-yyyy ....... done
start pull image kube-xxxx ......... done
....
start installation:
.... As for the problem this issue mentioned, we just don't give timeout limit to image pulling process, and keep previous timeout to other install operation. Thus, even though the sum time of installation could be unchanged, users can see at a glance that the slow installation is mainly due to slow image pulling. Users will feel that in addition to the image pulling process, the installation is fast and smooth. |
@Vacant2333 Can you show us which pieces of code we need to update? |
How to |
you can check my pr, there is 3 task need to be update |
This requires some exploration, simply thought, if it is just based on Kind, it can be done like this: docker pull registry.k8s.io/etcd:3.5.9-0
kind load docker-image registry.k8s.io/etcd:3.5.9-0 --name karmada-host But this is not a generic approach, for not all k8s is based on Kind, generic approach may need execute docker exec -it karmada-host-control-plane bash
root@karmada-host-control-plane:/# crictl --debug pull registry.k8s.io/etcd:3.5.9-0
DEBU[0000] get image connection
DEBU[0000] PullImageRequest: &PullImageRequest{Image:&ImageSpec{Image:registry.k8s.io/etcd:3.5.9-0,Annotations:map[string]string{},},Auth:nil,SandboxConfig:nil,}
DEBU[0078] PullImageResponse: &PullImageResponse{ImageRef:sha256:73deb9a3f702532592a4167455f8bf2e5f5d900bcc959ba2fd2d35c321de1af9,}
Image is up to date for sha256:73deb9a3f702532592a4167455f8bf2e5f5d900bcc959ba2fd2d35c321de1af9 But this is just a bit of thinking and requires more exploration. |
What happened:
When deploying Karmada using the operator, it's important to note that for the three components - karmada-etcd, karmada-apiserver, and karmada-aggregated-apiserver - their timeout is set to 30 seconds. In my environment (and even in most environments), if the images are not pre-pulled beforehand, the allotted time might not be sufficient. As a result, deployment could fail due to timeouts, necessitating the deletion of the Karmada resource before reattempting the deployment.
What you expected to happen:
Install success at once
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
![83d4c1419dcaa875d2e74015433b0c5d](https://private-user-images.githubusercontent.com/19872346/260384686-efbb1ef3-6d0c-44b8-8505-60d8b0479914.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5ODMzNTcsIm5iZiI6MTcxOTk4MzA1NywicGF0aCI6Ii8xOTg3MjM0Ni8yNjAzODQ2ODYtZWZiYjFlZjMtNmQwYy00NGI4LTg1MDUtNjBkOGIwNDc5OTE0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAzVDA1MDQxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ5NzBiNzMwYmVkNGJmNDYwY2ViNDAyZjFkYmNhMjAwYzM3MTlmZmM1OTA0ZTZkMjEzN2UzNzc4MzhmOWE1YTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.XmL_R0EE9VNyuElhRCGgUpq_oZHJdYtbDglgqzXiwcQ)
![0a71d6f83ce6c6e7d54441112e12d838](https://private-user-images.githubusercontent.com/19872346/260384711-a7f5cf1d-43fa-4ede-8fc8-1ed9ee49de43.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5ODMzNTcsIm5iZiI6MTcxOTk4MzA1NywicGF0aCI6Ii8xOTg3MjM0Ni8yNjAzODQ3MTEtYTdmNWNmMWQtNDNmYS00ZWRlLThmYzgtMWVkOWVlNDlkZTQzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAzVDA1MDQxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE4ZWRmNjc5M2FkMjU0YTU5NWFlNGZhMmZjOWFlZTI5NTkxMTRhYzJmODc0OWMyNGVlZmRiYTg4MDgzZDczZjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.hClBQSJ4lyFYRu54zzLvnmTthNM5Mc_5rOMf-cPbRGA)
![7bf89d25c6f9cd31f726b821206899e9](https://private-user-images.githubusercontent.com/19872346/260384721-65d27f88-f33d-4017-8dee-a01cc28faa4e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5ODMzNTcsIm5iZiI6MTcxOTk4MzA1NywicGF0aCI6Ii8xOTg3MjM0Ni8yNjAzODQ3MjEtNjVkMjdmODgtZjMzZC00MDE3LThkZWUtYTAxY2MyOGZhYTRlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAzVDA1MDQxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcyN2ZmZWE3MjA2OTIwMDhiNmM5MGVkZTViOGZkYzk1Y2Q4M2U3MTViNzU4NjFkYzU1OGRlNmU3NzJhZjllMWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.v3SjcYEvlzxcoeQfrLV-y0RabT4HwFCsHcnXIe0YYSY)
![image](https://private-user-images.githubusercontent.com/19872346/260384901-abeecb4c-73cf-4a06-86e7-6b36f70c5689.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5ODMzNTcsIm5iZiI6MTcxOTk4MzA1NywicGF0aCI6Ii8xOTg3MjM0Ni8yNjAzODQ5MDEtYWJlZWNiNGMtNzNjZi00YTA2LTg2ZTctNmIzNmY3MGM1Njg5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAzVDA1MDQxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc5YTQ1Nzg5NzkxNzBiMjJlODFlMTM5MDY3MzE5Yjc3ODViMjgwNThmYmM2MjA3YjJjOWM3MzI1NzNkZGMzYjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.GLriqv1SpgPSmEJjOln5RmumoFZt2d2qhV8v8XcpRUY)
The text was updated successfully, but these errors were encountered: