fix: ignore EOF error on Windows directory scanning #71
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In karrick#68, the scanner now returns any error that was encountered. On Windows, the call to Readdir will return an EOF when it is done reading a directory. I believe the desired behavior is to throw an error on any actual errors, but in the case of EOF, continue on to the next directory. As such, check for the EOF and return no error while releasing resources. fixes: karrick#70
|
Hmm the test error is: This also appears on master currently, but error code 1. Here is local running, with go1.19: |
xuyang2
reviewed
Feb 1, 2023
|
@xuyang2 thanks! seems to resolved the test failure as well :) |
|
@karrick anything I can do to help this along? |
|
@xuyang2 We're also interested in this fix - is there an estimate as to when this is going to be released? |
|
@karrick Is this project still active? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #68, the scanner now returns any error that was encountered. On Windows, the call to Readdir will return an EOF when it is done reading a directory.
I believe the desired behavior is to throw an error on any actual errors, but in the case of EOF, continue on to the next directory. As such, check for the EOF and return no error while releasing resources.
A user can test this PR by using the walk-fast example:
Currently, this will throw an EOF error after the first directory. With this fix, all the sub-directories will be traversed and return successfully.
fixes: #70